Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 5 update #252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Django 5 update #252

wants to merge 2 commits into from

Conversation

BBooijLiewes
Copy link
Contributor

@BBooijLiewes BBooijLiewes commented Dec 18, 2024

  • Update github ci testing matrix
    Note that python 3.8 and django 5 are not compatible so add an exception
    not to run that combination

  • Update timezone import
    Starting from django 5 the utc timezone should be imported from the
    default python datetime library instead of the django specific library

  • Fix get_fixed_timezone
    The get_fixed_timezone method however is still needed from the django
    library so import that seperatly

- Update github ci testing matrix
Note that python 3.8 and django 5 are not compatible so add an exception
not to run that combination

- Update timezone import
Starting from django 5 the utc timezone should be imported from the
default python datetime library instead of the django specific library

- Fix get_fixed_timezone
The get_fixed_timezone method however is still needed from the django
library so import that seperatly
This particular case is still used in older projects. So lets make sure
we test this combination as well.
@BBooijLiewes BBooijLiewes marked this pull request as ready for review December 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant